-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple tests with refactoring driver for duplicate class. #16853
Conversation
Argh, I did merge the revert in the meantime so now this is a conflict. |
I am doing a revert of the revert: #16854 |
Thanks, I will check further fails and check better next time. |
Revert fixed the conflicts, tests are now run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this adds one more failing testNoUncategorizedMethods
…in ReClassForGeneratingEqualAndHashExistingImplementors
Now load fails:
|
Now all the test that the revert fixed are failing:
In addition, we have: ReleaseTest>>testUndeclared It might fix other, but honestly, I am starting to get lost completely Might it not be a better idea to revert ? |
Hi Marcus, I agree with you. We should revert. That was the rule we set. @hernanmd it is important for us that this gets fixed fast, either by reverting or by fixing it. |
Hi @MarcusDenker, could you share a link to see the failed tests? |
Add wrongly deleted methods and instance variables in ReCopyClassRefactoring. Re-add wrongly deleted SycCmDuplicateClassCommand.
Thanks! |
Fix a couple of tests failing, reported in #16850, due to missing support to pre-configure refactorings for test purposes.
Also configured missing mocks for the preview presenter.
Fix also for #16825